hw/9pfs: Don't crash when we get a request with not supported 9p operation
authorAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Wed, 1 Jun 2011 07:05:14 +0000 (12:35 +0530)
committerVenkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Wed, 1 Jun 2011 17:25:27 +0000 (10:25 -0700)
Return EOPNOTSUPP as error

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
hw/9pfs/virtio-9p.c

index ec97b10f4954e90e68cd445a3fced5d9c7467dd0..ed081393a9d5c606912243d0b81cea9d7c41fdc7 100644 (file)
@@ -3606,6 +3606,11 @@ static pdu_handler_t *pdu_handlers[] = {
     [P9_TREMOVE] = v9fs_remove,
 };
 
+static void v9fs_op_not_supp(V9fsState *s, V9fsPDU *pdu)
+{
+    complete_pdu(s, pdu, -EOPNOTSUPP);
+}
+
 static void submit_pdu(V9fsState *s, V9fsPDU *pdu)
 {
     pdu_handler_t *handler;
@@ -3613,12 +3618,12 @@ static void submit_pdu(V9fsState *s, V9fsPDU *pdu)
     if (debug_9p_pdu) {
         pprint_pdu(pdu);
     }
-
-    BUG_ON(pdu->id >= ARRAY_SIZE(pdu_handlers));
-
-    handler = pdu_handlers[pdu->id];
-    BUG_ON(handler == NULL);
-
+    if (pdu->id >= ARRAY_SIZE(pdu_handlers) ||
+        (pdu_handlers[pdu->id] == NULL)) {
+        handler = v9fs_op_not_supp;
+    } else {
+        handler = pdu_handlers[pdu->id];
+    }
     handler(s, pdu);
 }