ice: use repr instead of vf->repr
authorMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tue, 24 Oct 2023 11:09:19 +0000 (13:09 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 13 Nov 2023 19:42:14 +0000 (11:42 -0800)
Extract repr from vf->repr as it is often use in the ice_repr_rem().

Remove meaningless clearing of q_vector and netdev pointers as kfree is
called on repr pointer.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_repr.c

index a2dc216c964fb4068990fb1bea035693c51f2fbd..903a3385eacb415030277b3715b68c29ad27ed07 100644 (file)
@@ -355,16 +355,16 @@ err_alloc:
  */
 static void ice_repr_rem(struct ice_vf *vf)
 {
-       if (!vf->repr)
+       struct ice_repr *repr = vf->repr;
+
+       if (!repr)
                return;
 
-       kfree(vf->repr->q_vector);
-       vf->repr->q_vector = NULL;
-       unregister_netdev(vf->repr->netdev);
+       kfree(repr->q_vector);
+       unregister_netdev(repr->netdev);
        ice_devlink_destroy_vf_port(vf);
-       free_netdev(vf->repr->netdev);
-       vf->repr->netdev = NULL;
-       kfree(vf->repr);
+       free_netdev(repr->netdev);
+       kfree(repr);
        vf->repr = NULL;
 
        ice_virtchnl_set_dflt_ops(vf);