platform/x86: hp-wmi: Introduce HPWMI_POWER_FW_OR_HW as convenient shortcut
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 15 May 2020 13:41:04 +0000 (16:41 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Sat, 30 May 2020 14:43:31 +0000 (17:43 +0300)
For hardware blocked wireless switch we check two bits. Introduce
HPWMI_POWER_FW_OR_HW enum to increase readability and for easier
maintenance.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/hp-wmi.c

index 4e3cee5247cc9288e2ac8a6d944e509946b5cee0..1762f335bac923c14e8229d821b36ef104b85fb1 100644 (file)
@@ -111,10 +111,10 @@ enum hp_wireless2_bits {
        HPWMI_POWER_SOFT        = 0x02,
        HPWMI_POWER_BIOS        = 0x04,
        HPWMI_POWER_HARD        = 0x08,
+       HPWMI_POWER_FW_OR_HW    = HPWMI_POWER_BIOS | HPWMI_POWER_HARD,
 };
 
-#define IS_HWBLOCKED(x) ((x & (HPWMI_POWER_BIOS | HPWMI_POWER_HARD)) \
-                        != (HPWMI_POWER_BIOS | HPWMI_POWER_HARD))
+#define IS_HWBLOCKED(x) ((x & HPWMI_POWER_FW_OR_HW) != HPWMI_POWER_FW_OR_HW)
 #define IS_SWBLOCKED(x) !(x & HPWMI_POWER_SOFT)
 
 struct bios_rfkill2_device_state {