iio: adc: rzg2l_adc: Use device_for_each_child_node_scoped()
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 24 Feb 2024 12:32:10 +0000 (12:32 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 25 Mar 2024 19:50:10 +0000 (19:50 +0000)
Switching to the _scoped() version removes the need for manual
calling of fwnode_handle_put() in the paths where the code
exits the loop early. In this case that's all in error paths.

Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20240224123215.161469-5-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/rzg2l_adc.c

index 0921ff2d9b3a10d9b748a85bc52b5ab1d33b820c..cd3a7e46ea53c009f29432535d71d02c5d63d25c 100644 (file)
@@ -302,7 +302,6 @@ static irqreturn_t rzg2l_adc_isr(int irq, void *dev_id)
 static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l_adc *adc)
 {
        struct iio_chan_spec *chan_array;
-       struct fwnode_handle *fwnode;
        struct rzg2l_adc_data *data;
        unsigned int channel;
        int num_channels;
@@ -330,17 +329,13 @@ static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l
                return -ENOMEM;
 
        i = 0;
-       device_for_each_child_node(&pdev->dev, fwnode) {
+       device_for_each_child_node_scoped(&pdev->dev, fwnode) {
                ret = fwnode_property_read_u32(fwnode, "reg", &channel);
-               if (ret) {
-                       fwnode_handle_put(fwnode);
+               if (ret)
                        return ret;
-               }
 
-               if (channel >= RZG2L_ADC_MAX_CHANNELS) {
-                       fwnode_handle_put(fwnode);
+               if (channel >= RZG2L_ADC_MAX_CHANNELS)
                        return -EINVAL;
-               }
 
                chan_array[i].type = IIO_VOLTAGE;
                chan_array[i].indexed = 1;