drm/i915/psr: Do not update phy power state in case of non-eDP panel replay
authorJouni Högander <jouni.hogander@intel.com>
Fri, 5 Apr 2024 11:35:58 +0000 (14:35 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Mon, 8 Apr 2024 07:28:53 +0000 (10:28 +0300)
Currently panel replay is supporting only main link on mode -> Do not
update phy power state for non-eDP panel replay.

Bspec: 53370

v2: use intel_dp_is_edp to differentiate

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240405113602.992714-5-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index bd99b995327483dc6a035ec2fd65f1c8e44338bb..07c1ddec2d867625285daace189647b3a0ec9bfa 100644 (file)
@@ -1930,13 +1930,16 @@ static void intel_psr_enable_locked(struct intel_dp *intel_dp,
        if (!psr_interrupt_error_check(intel_dp))
                return;
 
-       if (intel_dp->psr.panel_replay_enabled)
+       if (intel_dp->psr.panel_replay_enabled) {
                drm_dbg_kms(&dev_priv->drm, "Enabling Panel Replay\n");
-       else
+       } else {
                drm_dbg_kms(&dev_priv->drm, "Enabling PSR%s\n",
                            intel_dp->psr.psr2_enabled ? "2" : "1");
+       }
+
+       if (intel_dp_is_edp(intel_dp))
+               intel_snps_phy_update_psr_power_state(&dig_port->base, true);
 
-       intel_snps_phy_update_psr_power_state(&dig_port->base, true);
        intel_psr_enable_sink(intel_dp);
        intel_psr_enable_source(intel_dp, crtc_state);
        intel_dp->psr.enabled = true;
@@ -2041,7 +2044,8 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp)
                                     CLKGATE_DIS_MISC_DMASC_GATING_DIS, 0);
        }
 
-       intel_snps_phy_update_psr_power_state(&dp_to_dig_port(intel_dp)->base, false);
+       if (intel_dp_is_edp(intel_dp))
+               intel_snps_phy_update_psr_power_state(&dp_to_dig_port(intel_dp)->base, false);
 
        /* Panel Replay on eDP is always using ALPM aux less. */
        if (intel_dp->psr.panel_replay_enabled && intel_dp_is_edp(intel_dp)) {