drm/sun4i: hdmi: Fix u64 div on 32bit arch
authorMaxime Ripard <mripard@kernel.org>
Mon, 4 Mar 2024 09:12:25 +0000 (10:12 +0100)
committerMaxime Ripard <mripard@kernel.org>
Thu, 14 Mar 2024 12:45:03 +0000 (13:45 +0100)
Commit 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and
mode_valid") changed the clock rate from an unsigned long to an unsigned
long long resulting in a a 64-bit division that might not be supported
on all platforms.

The resulted in compilation being broken at least for m68k, xtensa and
some arm configurations, at least.

Fixes: 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Closes: https://lore.kernel.org/r/CA+G9fYvG9KE15PGNoLu+SBVyShe+u5HBLQ81+kK9Zop6u=ywmw@mail.gmail.com/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403011839.KLiXh4wC-lkp@intel.com/
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20240304091225.366325-1-mripard@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

index 69001a3dc0df23380d4e5f3a3c973b9c73ba3065..2d1880c61b50d1316c3119c0d2fa2ac733d3396b 100644 (file)
@@ -166,7 +166,7 @@ sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector,
                                 unsigned long long clock)
 {
        const struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector);
-       unsigned long diff = clock / 200; /* +-0.5% allowed by HDMI spec */
+       unsigned long diff = div_u64(clock, 200); /* +-0.5% allowed by HDMI spec */
        long rounded_rate;
 
        if (mode->flags & DRM_MODE_FLAG_DBLCLK)