wifi: mt76: mt7996: disable AMSDU for non-data frames
authorPeter Chiu <chui-hao.chiu@mediatek.com>
Fri, 26 Jan 2024 09:09:14 +0000 (17:09 +0800)
committerFelix Fietkau <nbd@nbd.name>
Thu, 22 Feb 2024 08:55:18 +0000 (09:55 +0100)
Disable AMSDU for non-data frames to prevent TX token leak issues.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mac.c

index 63d34844c1223b0383983d94e816982b7855cbe3..0384fb059ddfc88498fb48f8953618c8139befee 100644 (file)
@@ -732,6 +732,9 @@ mt7996_mac_write_txwi_8023(struct mt7996_dev *dev, __le32 *txwi,
              FIELD_PREP(MT_TXD2_SUB_TYPE, fc_stype);
 
        txwi[2] |= cpu_to_le32(val);
+
+       if (wcid->amsdu)
+               txwi[3] |= cpu_to_le32(MT_TXD3_HW_AMSDU);
 }
 
 static void
@@ -862,8 +865,6 @@ void mt7996_mac_write_txwi(struct mt7996_dev *dev, __le32 *txwi,
                val |= MT_TXD3_PROTECT_FRAME;
        if (info->flags & IEEE80211_TX_CTL_NO_ACK)
                val |= MT_TXD3_NO_ACK;
-       if (wcid->amsdu)
-               val |= MT_TXD3_HW_AMSDU;
 
        txwi[3] = cpu_to_le32(val);
        txwi[4] = 0;