spi: s3c64xx: move common code outside if else
authorTudor Ambarus <tudor.ambarus@linaro.org>
Wed, 7 Feb 2024 12:04:23 +0000 (12:04 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 8 Feb 2024 16:33:33 +0000 (16:33 +0000)
Move common code outside if else to avoid code duplication.

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240207120431.2766269-10-tudor.ambarus@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c

index fc0fe81ac95f532a1f89f1a465fe0a0475f1e8b8..8c76894d0eb1183b9ef0356adf7713179b4508d1 100644 (file)
@@ -292,20 +292,18 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma,
        if (dma->direction == DMA_DEV_TO_MEM) {
                sdd = container_of((void *)dma,
                        struct s3c64xx_spi_driver_data, rx_dma);
-               config.direction = dma->direction;
                config.src_addr = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
                config.src_addr_width = sdd->cur_bpw / 8;
                config.src_maxburst = 1;
-               dmaengine_slave_config(dma->ch, &config);
        } else {
                sdd = container_of((void *)dma,
                        struct s3c64xx_spi_driver_data, tx_dma);
-               config.direction = dma->direction;
                config.dst_addr = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
                config.dst_addr_width = sdd->cur_bpw / 8;
                config.dst_maxburst = 1;
-               dmaengine_slave_config(dma->ch, &config);
        }
+       config.direction = dma->direction;
+       dmaengine_slave_config(dma->ch, &config);
 
        desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
                                       dma->direction, DMA_PREP_INTERRUPT);