target/arm: Verify sz=0 for Advanced SIMD scalar pairwise (fp16)
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 24 May 2024 23:20:20 +0000 (16:20 -0700)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 28 May 2024 13:29:01 +0000 (14:29 +0100)
All of these insns have "if sz == '1' then UNDEFINED" in their pseudocode.
Fixes a RISU miscompare for invalid insn 0x5ef0c87a.

Fixes: 5c36d89567c ("arm/translate-a64: add all FP16 ops in simd_scalar_pairwise")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240524232121.284515-7-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/tcg/translate-a64.c

index 5455ae3685088186251831a9b4c8b1e161938945..0bdddb8517ab3251b7e5d9d5936930e515f3b53b 100644 (file)
@@ -8006,7 +8006,7 @@ static void disas_simd_scalar_pairwise(DisasContext *s, uint32_t insn)
     case 0x2f: /* FMINP */
         /* FP op, size[0] is 32 or 64 bit*/
         if (!u) {
-            if (!dc_isar_feature(aa64_fp16, s)) {
+            if ((size & 1) || !dc_isar_feature(aa64_fp16, s)) {
                 unallocated_encoding(s);
                 return;
             } else {