projects
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
95a7788
)
Unneeded NULL check
author
Dr. David Alan Gilbert
<dgilbert@redhat.com>
Wed, 18 Nov 2015 11:48:41 +0000
(11:48 +0000)
committer
Juan Quintela
<quintela@redhat.com>
Thu, 19 Nov 2015 10:49:53 +0000
(11:49 +0100)
The check is unneccesary, we read the value at the start of the
thread, use it, and never change it. The value is checked to be
non-NULL before thread creation.
Spotted by coverity, CID
1339211
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c
patch
|
blob
|
history
diff --git
a/migration/migration.c
b/migration/migration.c
index 265d13a74f8afb5533c762d621a668756f7ec3dd..1a42aee412ce530df0582851771bb6553b7d1efe 100644
(file)
--- a/
migration/migration.c
+++ b/
migration/migration.c
@@
-1345,7
+1345,7
@@
static void *source_return_path_thread(void *opaque)
break;
}
}
- if (
rp &&
qemu_file_get_error(rp)) {
+ if (qemu_file_get_error(rp)) {
trace_source_return_path_thread_bad_end();
mark_source_rp_bad(ms);
}