wifi: hostap: fix stringop-truncations GCC warning

With GCC 13.1 and W=1 hostap has a warning:

drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3633:17: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]

fortify-string.h recommends not to use strncpy() so use strscpy() which fixes
the warning. Also now it's guarenteed that the string is NUL-terminated.

Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230613140918.389690-4-kvalo@kernel.org

diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
index 26287b129d186560e1964ade74a1c8b3aeb6d588..b4adfc190ae877fc54cd89bb6fb26a13fca0768b 100644 (file)
--- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
@@ -3630,7 +3630,7 @@ static int prism2_ioctl_get_encryption(local_info_t *local,
                param->u.crypt.key_len = 0;
                param->u.crypt.idx = 0xff;
        } else {
-               strncpy(param->u.crypt.alg, (*crypt)->ops->name,
+               strscpy(param->u.crypt.alg, (*crypt)->ops->name,
                        HOSTAP_CRYPT_ALG_NAME_LEN);
                param->u.crypt.key_len = 0;