RDMA/hns: Remove redundant 'phy_addr' in hns_roce_hem_list_find_mtt()
authorChengchang Tang <tangchengchang@huawei.com>
Thu, 22 Sep 2022 12:33:10 +0000 (20:33 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 27 Sep 2022 13:15:25 +0000 (10:15 -0300)
This parameter has never been used. Remove it to simplify the function.

Link: https://lore.kernel.org/r/20220922123315.3732205-8-xuhaoyue1@hisilicon.com
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_hem.c
drivers/infiniband/hw/hns/hns_roce_hem.h
drivers/infiniband/hw/hns/hns_roce_mr.c

index e8acd2839d7dfc0f161f3ae677220691bbf3f9ee..d0b75a2234d325d851b3817758c2e2fd1e64d996 100644 (file)
@@ -1462,19 +1462,17 @@ void hns_roce_hem_list_init(struct hns_roce_hem_list *hem_list)
 
 void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
                                 struct hns_roce_hem_list *hem_list,
-                                int offset, int *mtt_cnt, u64 *phy_addr)
+                                int offset, int *mtt_cnt)
 {
        struct list_head *head = &hem_list->btm_bt;
        struct hns_roce_hem_item *hem, *temp_hem;
        void *cpu_base = NULL;
-       u64 phy_base = 0;
        int nr = 0;
 
        list_for_each_entry_safe(hem, temp_hem, head, sibling) {
                if (hem_list_page_is_in_range(hem, offset)) {
                        nr = offset - hem->start;
                        cpu_base = hem->addr + nr * BA_BYTE_LEN;
-                       phy_base = hem->dma_addr + nr * BA_BYTE_LEN;
                        nr = hem->end + 1 - offset;
                        break;
                }
@@ -1483,8 +1481,5 @@ void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
        if (mtt_cnt)
                *mtt_cnt = nr;
 
-       if (phy_addr)
-               *phy_addr = phy_base;
-
        return cpu_base;
 }
index 6b888049e9a00c97a3bf31eab606079e1050fcdd..7d23d3c51da46b177f44a9c9f06ee9dcb5282116 100644 (file)
@@ -131,7 +131,7 @@ void hns_roce_hem_list_release(struct hns_roce_dev *hr_dev,
                               struct hns_roce_hem_list *hem_list);
 void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
                                 struct hns_roce_hem_list *hem_list,
-                                int offset, int *mtt_cnt, u64 *phy_addr);
+                                int offset, int *mtt_cnt);
 
 static inline void hns_roce_hem_first(struct hns_roce_hem *hem,
                                      struct hns_roce_hem_iter *iter)
index dedfa56f577312ab30dfae50159ee684bcb555a2..93615f2556b2f427f5267d276e7b6d722438f167 100644 (file)
@@ -585,7 +585,7 @@ static int mtr_map_region(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr,
        while (offset < end && npage < max_count) {
                count = 0;
                mtts = hns_roce_hem_list_find_mtt(hr_dev, &mtr->hem_list,
-                                                 offset, &count, NULL);
+                                                 offset, &count);
                if (!mtts)
                        return -ENOBUFS;
 
@@ -834,7 +834,7 @@ int hns_roce_mtr_find(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr,
                mtt_count = 0;
                mtts = hns_roce_hem_list_find_mtt(hr_dev, &mtr->hem_list,
                                                  start_index + total,
-                                                 &mtt_count, NULL);
+                                                 &mtt_count);
                if (!mtts || !mtt_count)
                        goto done;