scsi: ib_srp: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:00 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:43 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-6-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/infiniband/ulp/srp/ib_srp.c

index 71eda91e810cfee279a845f22f66ce6a35388494..f8765f96ec1e5795d4fee32a44f660317e7b6f5e 100644 (file)
@@ -1266,7 +1266,7 @@ static void srp_finish_req(struct srp_rdma_ch *ch, struct srp_request *req,
        if (scmnd) {
                srp_free_req(ch, req, scmnd, 0);
                scmnd->result = result;
-               scmnd->scsi_done(scmnd);
+               scsi_done(scmnd);
        }
 }
 
@@ -1987,7 +1987,7 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp)
                srp_free_req(ch, req, scmnd,
                             be32_to_cpu(rsp->req_lim_delta));
 
-               scmnd->scsi_done(scmnd);
+               scsi_done(scmnd);
        }
 }
 
@@ -2239,7 +2239,7 @@ err_iu:
 
 err:
        if (scmnd->result) {
-               scmnd->scsi_done(scmnd);
+               scsi_done(scmnd);
                ret = 0;
        } else {
                ret = SCSI_MLQUEUE_HOST_BUSY;
@@ -2811,7 +2811,7 @@ static int srp_abort(struct scsi_cmnd *scmnd)
        if (ret == SUCCESS) {
                srp_free_req(ch, req, scmnd, 0);
                scmnd->result = DID_ABORT << 16;
-               scmnd->scsi_done(scmnd);
+               scsi_done(scmnd);
        }
 
        return ret;