bpf: Remove test for MOVSX32 with offset=32
authorPuranjay Mohan <puranjay12@gmail.com>
Fri, 10 Nov 2023 17:51:50 +0000 (17:51 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 15 Nov 2023 20:46:27 +0000 (12:46 -0800)
MOVSX32 only supports sign extending 8-bit and 16-bit operands into 32
bit operands. The "ALU_MOVSX | BPF_W" test tries to sign extend a 32 bit
operand into a 32 bit operand which is equivalent to a normal BPF_MOV.

Remove this test as it tries to run an invalid instruction.

Fixes: daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")
Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202310111838.46ff5b6a-oliver.sang@intel.com
Acked-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20231110175150.87803-1-puranjay12@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
lib/test_bpf.c

index 7916503e6a6ab922bc9b3f10f408e029f3d2cc01..c148f8d1e5647eff03e3819226c80e38013787f0 100644 (file)
@@ -5144,22 +5144,6 @@ static struct bpf_test tests[] = {
                { },
                { { 0, 0x1 } },
        },
-       {
-               "ALU_MOVSX | BPF_W",
-               .u.insns_int = {
-                       BPF_LD_IMM64(R2, 0x00000000deadbeefLL),
-                       BPF_LD_IMM64(R3, 0xdeadbeefdeadbeefLL),
-                       BPF_MOVSX32_REG(R1, R3, 32),
-                       BPF_JMP_REG(BPF_JEQ, R2, R1, 2),
-                       BPF_MOV32_IMM(R0, 2),
-                       BPF_EXIT_INSN(),
-                       BPF_MOV32_IMM(R0, 1),
-                       BPF_EXIT_INSN(),
-               },
-               INTERNAL,
-               { },
-               { { 0, 0x1 } },
-       },
        /* MOVSX64 REG */
        {
                "ALU64_MOVSX | BPF_B",