tty: jsm: Remove redundant assignment to variable linestatus
authorColin Ian King <colin.i.king@gmail.com>
Fri, 16 Feb 2024 12:17:32 +0000 (12:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 Feb 2024 17:59:58 +0000 (18:59 +0100)
The variable linestate being assigned a value that is never read, the
following continue statement jumps to the end of the while-loop and then
it is re-assigned a new value. The assignment is redundant and can be
removed.

Cleans up clang scan build warning:
drivers/tty/serial/jsm/jsm_cls.c:398:4: warning: Value stored
to 'linestatus' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240216121732.2106445-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/jsm/jsm_cls.c

index 1eda48964c0b6539f0e6281d121d7b17344549b7..ddbd42c09637cdc9bcc2438367b53e2b4fb8f551 100644 (file)
@@ -395,7 +395,6 @@ static void cls_copy_data_from_uart_to_queue(struct jsm_channel *ch)
                 * which in this case is the break signal.
                 */
                if (linestatus & error_mask)  {
-                       linestatus = 0;
                        readb(&ch->ch_cls_uart->txrx);
                        continue;
                }