drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Mon, 15 Apr 2024 21:49:36 +0000 (17:49 -0400)
committerRobert Foss <rfoss@kernel.org>
Tue, 16 Apr 2024 13:19:06 +0000 (15:19 +0200)
Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.

Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels")
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-8-619a28148e5c@collabora.com
drivers/gpu/drm/panel/panel-novatek-nt35950.c

index 648ce9201426561ca2049d4c832d89f3e31109f9..028fdac293f77fd2186981eb07916d23708f4e34 100644 (file)
@@ -556,10 +556,8 @@ static int nt35950_probe(struct mipi_dsi_device *dsi)
                }
                dsi_r_host = of_find_mipi_dsi_host_by_node(dsi_r);
                of_node_put(dsi_r);
-               if (!dsi_r_host) {
-                       dev_err(dev, "Cannot get secondary DSI host\n");
-                       return -EPROBE_DEFER;
-               }
+               if (!dsi_r_host)
+                       return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n");
 
                nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);
                if (!nt->dsi[1]) {