pinctrl: baytrail: invert if condition
authorRaag Jadav <raag.jadav@intel.com>
Fri, 16 Jun 2023 20:33:56 +0000 (02:03 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 19 Jun 2023 10:53:26 +0000 (13:53 +0300)
Invert if condition and get rid of redundant else.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20230616203356.27343-4-raag.jadav@intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/intel/pinctrl-baytrail.c

index 97ead2c58b66592a889eb4f766862fe3f72a6f85..27aef62fc7c0473d01b557dab084c1e05ab69484 100644 (file)
@@ -753,9 +753,7 @@ static void byt_gpio_clear_triggering(struct intel_pinctrl *vg, unsigned int off
        value = readl(reg);
 
        /* Do not clear direct-irq enabled IRQs (from gpio_disable_free) */
-       if (value & BYT_DIRECT_IRQ_EN)
-               /* nothing to do */ ;
-       else
+       if (!(value & BYT_DIRECT_IRQ_EN))
                value &= ~(BYT_TRIG_POS | BYT_TRIG_NEG | BYT_TRIG_LVL);
 
        writel(value, reg);