virtio-pci: reset modern vq meta data
authorJason Wang <jasowang@redhat.com>
Tue, 14 Mar 2017 07:25:05 +0000 (15:25 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 15 Mar 2017 17:59:18 +0000 (19:59 +0200)
We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if
a driver enable the vq without setting vq address after reset. The old
addresses were leaked. Fixing this by resetting modern vq meta data
during device reset.

Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/virtio-pci.c

index 5ce42af9d44e6788feedb491abf552267ad82d2a..69cc471e5684f49f632b24b45a5c7579fe864f3c 100644 (file)
@@ -1857,6 +1857,10 @@ static void virtio_pci_reset(DeviceState *qdev)
 
     for (i = 0; i < VIRTIO_QUEUE_MAX; i++) {
         proxy->vqs[i].enabled = 0;
+        proxy->vqs[i].num = 0;
+        proxy->vqs[i].desc[0] = proxy->vqs[i].desc[1] = 0;
+        proxy->vqs[i].avail[0] = proxy->vqs[i].avail[1] = 0;
+        proxy->vqs[i].used[0] = proxy->vqs[i].used[1] = 0;
     }
 }