projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a5d8278
)
pinctrl: sprd: Simplify bool comparison
author
YANG LI
<abaci-bugfix@linux.alibaba.com>
Tue, 12 Jan 2021 08:28:00 +0000
(16:28 +0800)
committer
Linus Walleij
<linus.walleij@linaro.org>
Mon, 18 Jan 2021 13:41:42 +0000
(14:41 +0100)
Fix the following coccicheck warning:
./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
bool
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Link:
https://lore.kernel.org/r/1610440080-68600-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sprd/pinctrl-sprd.c
patch
|
blob
|
history
diff --git
a/drivers/pinctrl/sprd/pinctrl-sprd.c
b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 08dc1931b358d58e7a0a08e4cb36ceb1e32c0a62..dca7a505d4137799a5cc3cb89aa8fbc5b9edf20d 100644
(file)
--- a/
drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/
drivers/pinctrl/sprd/pinctrl-sprd.c
@@
-687,7
+687,7
@@
static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
shift = INPUT_SCHMITT_SHIFT;
break;
case PIN_CONFIG_BIAS_PULL_UP:
- if (is_sleep_config
== true
) {
+ if (is_sleep_config) {
val |= SLEEP_PULL_UP;
mask = SLEEP_PULL_UP_MASK;
shift = SLEEP_PULL_UP_SHIFT;