tty: hvcs: Drop unnecessary if block
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 14 Jan 2021 17:57:16 +0000 (18:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Feb 2021 00:21:43 +0000 (16:21 -0800)
If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if hvcs_probe() failed hvcs_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and
the check can just go away.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/tty/hvc/hvcs.c

index 55105ac38f89b3282877dd8359d687ca42e9b6fe..c6d1e6589edf50956d73b387199890ae2a32a00d 100644 (file)
@@ -825,9 +825,6 @@ static int hvcs_remove(struct vio_dev *dev)
        unsigned long flags;
        struct tty_struct *tty;
 
-       if (!hvcsd)
-               return -ENODEV;
-
        /* By this time the vty-server won't be getting any more interrupts */
 
        spin_lock_irqsave(&hvcsd->lock, flags);