staging: r8188eu: txpktbuf_bndy does not depend on wifi_spec
authorMartin Kaiser <martin@kaiser.cx>
Sat, 6 Aug 2022 19:43:04 +0000 (21:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2022 13:12:49 +0000 (15:12 +0200)
Remove the if clause that sets txpktbuf_bndy. Both branches set the same
value.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220806194304.777059-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/rtl8188e_hal.h

index ff074d246dab764e4215b60898703192a0573e5b..e3013017dc6e0ffe2869d1cd01a5cf8bc8517c99 100644 (file)
@@ -567,7 +567,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
 {
        u8 value8 = 0;
        u16  value16;
-       u8 txpktbuf_bndy;
        u32 status = _SUCCESS;
        int res;
        struct hal_data_8188e *haldata = &Adapter->haldata;
@@ -600,13 +599,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        /*  HW GPIO pin. Before PHY_RFConfig8192C. */
        /*  2010/08/26 MH If Efuse does not support sective suspend then disable the function. */
 
-       if (!pregistrypriv->wifi_spec) {
-               txpktbuf_bndy = TX_PAGE_BOUNDARY_88E;
-       } else {
-               /*  for WMM */
-               txpktbuf_bndy = WMM_NORMAL_TX_PAGE_BOUNDARY_88E;
-       }
-
        _InitQueueReservedPage(Adapter);
        _InitQueuePriority(Adapter);
        _InitPageBoundary(Adapter);
@@ -647,9 +639,9 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        if (status == _FAIL)
                goto exit;
 
-       _InitTxBufferBoundary(Adapter, txpktbuf_bndy);
+       _InitTxBufferBoundary(Adapter, TX_PAGE_BOUNDARY_88E);
 
-       status =  InitLLTTable(Adapter, txpktbuf_bndy);
+       status =  InitLLTTable(Adapter, TX_PAGE_BOUNDARY_88E);
        if (status == _FAIL)
                goto exit;
 
index 5cd62b21672037353192bc28420bd07f6aac704a..fdc187f4deaa446351289fdbb7e88b7e9259530f 100644 (file)
 
 #define TX_PAGE_BOUNDARY_88E (TX_TOTAL_PAGE_NUMBER_88E + 1)
 
-/* Note: For Normal Chip Setting ,modify later */
-#define WMM_NORMAL_TX_TOTAL_PAGE_NUMBER                        \
-       TX_TOTAL_PAGE_NUMBER_88E  /* 0xA9 , 0xb0=>176=>22k */
-#define WMM_NORMAL_TX_PAGE_BOUNDARY_88E                        \
-       (WMM_NORMAL_TX_TOTAL_PAGE_NUMBER + 1) /* 0xA9 */
-
 #include "HalVerDef.h"
 #include "hal_com.h"