ppc/pnv: Simplify pnv_bmc_create()
authorCédric Le Goater <clg@kaod.org>
Tue, 26 Jan 2021 17:10:56 +0000 (18:10 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Tue, 9 Feb 2021 23:43:50 +0000 (10:43 +1100)
and reuse pnv_bmc_set_pnor() to share the setting of the PNOR.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210126171059.307867-5-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/pnv_bmc.c

index 67ebb16c4d5f49439afd68f139cabe5c6018fa75..86d16b493539f1cda36b97682be050129396ad7a 100644 (file)
@@ -260,13 +260,8 @@ IPMIBmc *pnv_bmc_create(PnvPnor *pnor)
     Object *obj;
 
     obj = object_new(TYPE_IPMI_BMC_SIMULATOR);
-    object_ref(OBJECT(pnor));
-    object_property_add_const_link(obj, "pnor", OBJECT(pnor));
     qdev_realize(DEVICE(obj), NULL, &error_fatal);
-
-    /* Install the HIOMAP protocol handlers to access the PNOR */
-    ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM,
-                            &hiomap_netfn);
+    pnv_bmc_set_pnor(IPMI_BMC(obj), pnor);
 
     return IPMI_BMC(obj);
 }