lib/test: use after free in register_test_dev_kmod()

[ Upstream commit dc0ce6cc4b133f5f2beb8b47dacae13a7d283c2c ]

The "test_dev" pointer is freed but then returned to the caller.

Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ce15893914131efd5723737bb34b5f0bf62af4fb..cb800b1d0d99c0d77ffeaae4d9e32adbceb756e4 100644 (file)
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1149,6 +1149,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
        if (ret) {
                pr_err("could not register misc device: %d\n", ret);
                free_test_dev_kmod(test_dev);
+               test_dev = NULL;
                goto out;
        }