arm64: hibernate: remove WARN_ON in save_processor_state
authorSong Shuai <songshuaishuai@tinylab.org>
Fri, 9 Jun 2023 07:50:47 +0000 (15:50 +0800)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 21 Jun 2023 12:33:49 +0000 (13:33 +0100)
During hibernation or restoration, freeze_secondary_cpus
checks num_online_cpus via BUG_ON, and the subsequent
save_processor_state also does the checking with WARN_ON.

In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
is not defined, but the sole possible condition to disable
CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
We also don't have to check it in save_processor_state.

So remove the unnecessary checking in save_processor_state.

Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20230609075049.2651723-3-songshuaishuai@tinylab.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/hibernate.c

index 788597a6b6a2f01ddfa7eae4c67802b3d50d359e..02870beb271ed35ccbbb7a3dad71399502974946 100644 (file)
@@ -99,7 +99,6 @@ int pfn_is_nosave(unsigned long pfn)
 
 void notrace save_processor_state(void)
 {
-       WARN_ON(num_online_cpus() != 1);
 }
 
 void notrace restore_processor_state(void)