accel/nvmm: Fix NULL dereference in nvmm_init_vcpu()
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 29 Apr 2024 09:11:04 +0000 (11:11 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 3 May 2024 12:37:51 +0000 (14:37 +0200)
When mechanically moving the @dirty field to AccelCPUState
in commit 79f1926b2d, we neglected cpu->accel is still NULL
when we want to dereference it.

Reported-by: Volker Rümelin <vr_qemu@t-online.de>
Suggested-by: Volker Rümelin <vr_qemu@t-online.de>
Fixes: 79f1926b2d ("accel/nvmm: Use accel-specific per-vcpu @dirty field")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240429091918.27429-3-philmd@linaro.org>

target/i386/nvmm/nvmm-all.c

index f9cced53b3f14e336e82d9078f4641d799c366e9..65768aca037e17ec2db6f468d121f14ed98e1c73 100644 (file)
@@ -982,7 +982,7 @@ nvmm_init_vcpu(CPUState *cpu)
         }
     }
 
-    cpu->accel->dirty = true;
+    qcpu->dirty = true;
     cpu->accel = qcpu;
 
     return 0;