scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer

'tdata' pointer will never be NULL so remove NULL checks.

Link: https://lore.kernel.org/r/1595505391-3335-1-git-send-email-varun@chelsio.com
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 932dbd4c4cca77daa56968a3d231fee385a80974..71aebaf533ea543dd4ec701aab5166036ed020bc 100644 (file)
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -1899,7 +1899,7 @@ int cxgbi_conn_alloc_pdu(struct iscsi_task *task, u8 op)
        u32 last_tdata_offset, last_tdata_count;
        int err = 0;
 
-       if (!tcp_task || !tdata) {
+       if (!tcp_task) {
                pr_err("task 0x%p, tcp_task 0x%p, tdata 0x%p.\n",
                       task, tcp_task, tdata);
                return -ENOMEM;
@@ -2155,7 +2155,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
        struct page *pg;
        int err;
 
-       if (!tcp_task || !tdata || tcp_task->dd_data != tdata) {
+       if (!tcp_task || (tcp_task->dd_data != tdata)) {
                pr_err("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
                       task, task->sc, tcp_task,
                       tcp_task ? tcp_task->dd_data : NULL, tdata);
@@ -2371,7 +2371,7 @@ int cxgbi_conn_xmit_pdu(struct iscsi_task *task)
        u32 datalen;
        int err;
 
-       if (!tcp_task || !tdata || (tcp_task->dd_data != tdata)) {
+       if (!tcp_task || (tcp_task->dd_data != tdata)) {
                pr_err("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
                       task, task->sc, tcp_task,
                       tcp_task ? tcp_task->dd_data : NULL, tdata);
@@ -2472,7 +2472,7 @@ void cxgbi_cleanup_task(struct iscsi_task *task)
        struct iscsi_tcp_task *tcp_task = task->dd_data;
        struct cxgbi_task_data *tdata = iscsi_task_cxgbi_data(task);
 
-       if (!tcp_task || !tdata || (tcp_task->dd_data != tdata)) {
+       if (!tcp_task || (tcp_task->dd_data != tdata)) {
                pr_info("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
                        task, task->sc, tcp_task,
                        tcp_task ? tcp_task->dd_data : NULL, tdata);