video: fbdev: pxa3xx-gcu: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Fri, 17 Sep 2021 04:22:09 +0000 (12:22 +0800)
committerHelge Deller <deller@gmx.de>
Sat, 29 Jan 2022 22:22:36 +0000 (23:22 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/pxa3xx-gcu.c

index 4279e13a3b58dc9d972b7c35baea32ca68ccbac8..9239ecd34169356eb8bda26153db3c7239424a59 100644 (file)
@@ -606,10 +606,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
 
        /* enable the clock */
        priv->clk = devm_clk_get(dev, NULL);
-       if (IS_ERR(priv->clk)) {
-               dev_err(dev, "failed to get clock\n");
-               return PTR_ERR(priv->clk);
-       }
+       if (IS_ERR(priv->clk))
+               return dev_err_probe(dev, PTR_ERR(priv->clk), "failed to get clock\n");
 
        /* request the IRQ */
        irq = platform_get_irq(pdev, 0);