platform/x86: msi-ec: Fix the 3rd config
authorNikita Kravets <teackot@gmail.com>
Fri, 6 Oct 2023 17:53:53 +0000 (20:53 +0300)
committerHans de Goede <hdegoede@redhat.com>
Wed, 11 Oct 2023 09:22:06 +0000 (11:22 +0200)
Fix the charge control address of CONF3 and remove an incorrect firmware
version which turned out to be a BIOS firmware and not an EC firmware.

Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver")
Cc: Aakash Singh <mail@singhaakash.dev>
Cc: Jose Angel Pastrana <japp0005@red.ujaen.es>
Signed-off-by: Nikita Kravets <teackot@gmail.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231006175352.1753017-5-teackot@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/msi-ec.c

index f26a3121092f9790ea78567d4db97ae17211cbf2..492eb383ee7a9c4ff9181009963533c106eb8252 100644 (file)
@@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = {
 
 static const char * const ALLOWED_FW_3[] __initconst = {
        "1592EMS1.111",
-       "E1592IMS.10C",
        NULL
 };
 
 static struct msi_ec_conf CONF3 __initdata = {
        .allowed_fw = ALLOWED_FW_3,
        .charge_control = {
-               .address      = 0xef,
+               .address      = 0xd7,
                .offset_start = 0x8a,
                .offset_end   = 0x80,
                .range_min    = 0x8a,