media: hantro: postproc: Properly calculate chroma offset
authorJernej Skrabec <jernej.skrabec@gmail.com>
Wed, 6 Jul 2022 18:28:59 +0000 (19:28 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 17 Jul 2022 10:00:58 +0000 (11:00 +0100)
Currently chroma offset calculation assumes only 1 byte per luma, with
no consideration for stride.

Take necessary information from destination pixel format which makes
calculation completely universal.

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Tested-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/hantro/hantro_postproc.c

index 8933b4af73edbd3b44b8db62484c8189d2a35d29..a0928c508434201cb61dc6fa0e669c2dfd644778 100644 (file)
@@ -113,12 +113,14 @@ static void hantro_postproc_g2_enable(struct hantro_ctx *ctx)
 {
        struct hantro_dev *vpu = ctx->dev;
        struct vb2_v4l2_buffer *dst_buf;
-       size_t chroma_offset = ctx->dst_fmt.width * ctx->dst_fmt.height;
        int down_scale = down_scale_factor(ctx);
+       size_t chroma_offset;
        dma_addr_t dst_dma;
 
        dst_buf = hantro_get_dst_buf(ctx);
        dst_dma = vb2_dma_contig_plane_dma_addr(&dst_buf->vb2_buf, 0);
+       chroma_offset = ctx->dst_fmt.plane_fmt[0].bytesperline *
+                       ctx->dst_fmt.height;
 
        if (down_scale) {
                hantro_reg_write(vpu, &g2_down_scale_e, 1);