x86/sev: Change npages to unsigned long in snp_accept_memory()
authorTom Lendacky <thomas.lendacky@amd.com>
Thu, 22 Jun 2023 13:45:05 +0000 (08:45 -0500)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 2 Oct 2023 12:55:41 +0000 (14:55 +0200)
In snp_accept_memory(), the npages variables value is calculated from
phys_addr_t variables but is an unsigned int. A very large range passed
into snp_accept_memory() could lead to truncating npages to zero. This
doesn't happen at the moment but let's be prepared.

Fixes: 6c3211796326 ("x86/sev: Add SNP-specific unaccepted memory support")
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Cc: <stable@kernel.org>
Link: https://lore.kernel.org/r/6d511c25576494f682063c9fb6c705b526a3757e.1687441505.git.thomas.lendacky@amd.com
arch/x86/kernel/sev.c

index 2787826d9f607798da1d2b2fca4d8550a601eb0c..d8c1e3be74c0b6edba5c88e7d6e921da11f44a2a 100644 (file)
@@ -868,8 +868,7 @@ void snp_set_memory_private(unsigned long vaddr, unsigned long npages)
 
 void snp_accept_memory(phys_addr_t start, phys_addr_t end)
 {
-       unsigned long vaddr;
-       unsigned int npages;
+       unsigned long vaddr, npages;
 
        if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
                return;