migration/multifd: Avoid the final FLUSH in complete()
authorPeter Xu <peterx@redhat.com>
Wed, 19 Jun 2024 22:30:36 +0000 (18:30 -0400)
committerFabiano Rosas <farosas@suse.de>
Fri, 21 Jun 2024 12:47:59 +0000 (09:47 -0300)
We always do the flush when finishing one round of scan, and during
complete() phase we should scan one more round making sure no dirty page
existed.  In that case we shouldn't need one explicit FLUSH at the end of
complete(), as when reaching there all pages should have been flushed.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Tested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/ram.c

index ceea586b06baa3a08866a61ca2773da351cf19bb..edec1a2d073bb752814da300817d5e4fc6955ef9 100644 (file)
@@ -3300,10 +3300,6 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
         }
     }
 
-    if (migrate_multifd() && !migrate_multifd_flush_after_each_section() &&
-        !migrate_mapped_ram()) {
-        qemu_put_be64(f, RAM_SAVE_FLAG_MULTIFD_FLUSH);
-    }
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
     return qemu_fflush(f);
 }