openrisc: ptrace: user_regset_copyin_ignore() always returns 0
authorSergey Shtylyov <s.shtylyov@omp.ru>
Fri, 14 Oct 2022 21:22:30 +0000 (00:22 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 15 Nov 2022 22:30:40 +0000 (14:30 -0800)
user_regset_copyin_ignore() always returns 0, so checking its result seems
pointless -- don't do this anymore...

Link: https://lkml.kernel.org/r/20221014212235.10770-9-s.shtylyov@omp.ru
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Brian Cain <bcain@quicinc.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: David S. Miller <davem@davemloft.net>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jonas Bonn <jonas@southpole.se>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Rich Felker <dalias@libc.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshinori Sato <ysato@users.osdn.me>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/openrisc/kernel/ptrace.c

index b971740fc2aa982a7c683fe69b1b75fc24df2b98..85ace93fc251fa89ca3bd4782a4cdaa11499cacb 100644 (file)
@@ -66,10 +66,9 @@ static int genregs_set(struct task_struct *target,
        int ret;
 
        /* ignore r0 */
-       ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, 0, 4);
+       user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, 0, 4);
        /* r1 - r31 */
-       if (!ret)
-               ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
+       ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
                                         regs->gpr+1, 4, 4*32);
        /* PC */
        if (!ret)
@@ -80,8 +79,7 @@ static int genregs_set(struct task_struct *target,
         * the Supervision register
         */
        if (!ret)
-               ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf,
-                                               4*33, -1);
+               user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, 4*33, -1);
 
        return ret;
 }