char: don't silently skip tn3270 protocol init when TLS is enabled
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 21 Dec 2017 10:52:37 +0000 (10:52 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 13 Mar 2018 16:32:15 +0000 (16:32 +0000)
Even if common tn3270 implementations do not support TLS, it is trivial to
have them proxied over a proxy like stunnel which adds TLS at the sockets
layer. We should thus not silently skip tn3270 protocol initialization
when TLS is enabled.

Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
chardev/char-socket.c

index a220803c012383c52b7c3f1ed3bad9b7b7ae9d92..1a371b91ac3d5d279806fc0ed000ec3e1f3ff229 100644 (file)
@@ -663,8 +663,7 @@ static void tcp_chr_tls_handshake(QIOTask *task,
     if (qio_task_propagate_error(task, NULL)) {
         tcp_chr_disconnect(chr);
     } else {
-        /* tn3270 does not support TLS yet */
-        if (s->do_telnetopt && !s->is_tn3270) {
+        if (s->do_telnetopt) {
             tcp_chr_telnet_init(chr);
         } else {
             tcp_chr_connect(chr);