ALSA: pdaudiocf: Drop superfluous GFP setup
authorTakashi Iwai <tiwai@suse.de>
Tue, 23 Aug 2022 11:57:37 +0000 (13:57 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 24 Aug 2022 06:00:26 +0000 (08:00 +0200)
The extra setup with GFP_DMA32 is superfluous for this driver.  The
whole operation is a simple copy loop, and there is no memory address
restriction at all.  Drop the useless GFP setup.

Link: https://lore.kernel.org/r/20220823115740.14123-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c

index dfc4295b69c413a5164a932d98f9f38313aa8126..aaa82ec36540d0b7bfec6ca897d990d09ec03143 100644 (file)
@@ -257,8 +257,7 @@ int snd_pdacf_pcm_new(struct snd_pdacf *chip)
                return err;
                
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pdacf_pcm_capture_ops);
-       snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC,
-                                      snd_dma_continuous_data(GFP_KERNEL | GFP_DMA32),
+       snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC, NULL,
                                       0, 0);
 
        pcm->private_data = chip;