wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured
authorPing-Ke Shih <pkshih@realtek.com>
Tue, 13 Feb 2024 12:25:56 +0000 (20:25 +0800)
committerKalle Valo <kvalo@kernel.org>
Thu, 15 Feb 2024 11:10:24 +0000 (13:10 +0200)
The rcu_read_unlock() is accidentally added, and sparse warn:

  drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
    warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock

Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240213122556.9593-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/fw.c

index 2ab45d0878f7e48ada2788db9565ca0d3327aaca..63897351ca151f55f4e9f83e4ccc63b87ff2f051 100644 (file)
@@ -2808,7 +2808,6 @@ int rtw89_fw_h2c_assoc_cmac_tbl_g7(struct rtw89_dev *rtwdev,
 
                h2c->w4 |= le32_encode_bits(~punct,
                                            CCTLINFO_G7_W4_ACT_SUBCH_CBW);
-               rcu_read_unlock();
                h2c->m4 |= cpu_to_le32(CCTLINFO_G7_W4_ACT_SUBCH_CBW);
        }