serial: 8250_dwlib: RS485 HW half & full duplex support

The Synopsys DesignWare UART can be configured to have HW support for
the RS485 protocol from IP version 4.0 onward. Add support for
hardware-controlled half duplex and full duplex modes.

HW will take care of managing DE and RE, the driver just gives it
permission to use either by setting both to 1.

To ask for full duplex mode, userspace sets SER_RS485_RX_DURING_TX flag
and HW will take care of the rest.

Set delay_rts_before_send and delay_rts_after_send to zero for now. The
granularity of that ABI is too coarse to be useful.

Co-developed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Co-developed-by: Raymond Tan <raymond.tan@intel.com>
Signed-off-by: Raymond Tan <raymond.tan@intel.com>
Co-developed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220426122448.38997-2-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/8250/8250_dwlib.c b/drivers/tty/serial/8250/8250_dwlib.c
index b3df6dee9ceb2959af17507a316fb549d74f43b3..05b73c8e75bca5db5803ad03e96c2be71ec9088a 100644 (file)
--- a/drivers/tty/serial/8250/8250_dwlib.c
+++ b/drivers/tty/serial/8250/8250_dwlib.c
@@ -2,18 +2,32 @@
 /* Synopsys DesignWare 8250 library. */
 
 #include <linux/bitops.h>
+#include <linux/bitfield.h>
 #include <linux/device.h>
 #include <linux/kernel.h>
+#include <linux/property.h>
 #include <linux/serial_8250.h>
 #include <linux/serial_core.h>
 
 #include "8250_dwlib.h"
 
 /* Offsets for the DesignWare specific registers */
+#define DW_UART_TCR    0xac /* Transceiver Control Register (RS485) */
+#define DW_UART_DE_EN  0xb0 /* Driver Output Enable Register */
+#define DW_UART_RE_EN  0xb4 /* Receiver Output Enable Register */
 #define DW_UART_DLF    0xc0 /* Divisor Latch Fraction Register */
 #define DW_UART_CPR    0xf4 /* Component Parameter Register */
 #define DW_UART_UCV    0xf8 /* UART Component Version */
 
+/* Transceiver Control Register bits */
+#define DW_UART_TCR_RS485_EN           BIT(0)
+#define DW_UART_TCR_RE_POL             BIT(1)
+#define DW_UART_TCR_DE_POL             BIT(2)
+#define DW_UART_TCR_XFER_MODE          GENMASK(4, 3)
+#define DW_UART_TCR_XFER_MODE_DE_DURING_RE     FIELD_PREP(DW_UART_TCR_XFER_MODE, 0)
+#define DW_UART_TCR_XFER_MODE_SW_DE_OR_RE      FIELD_PREP(DW_UART_TCR_XFER_MODE, 1)
+#define DW_UART_TCR_XFER_MODE_DE_OR_RE         FIELD_PREP(DW_UART_TCR_XFER_MODE, 2)
+
 /* Component Parameter Register bits */
 #define DW_UART_CPR_ABP_DATA_WIDTH     (3 << 0)
 #define DW_UART_CPR_AFCE_MODE          (1 << 4)
@@ -71,6 +85,70 @@ void dw8250_do_set_termios(struct uart_port *p, struct ktermios *termios, struct
 }
 EXPORT_SYMBOL_GPL(dw8250_do_set_termios);
 
+static int dw8250_rs485_config(struct uart_port *p, struct serial_rs485 *rs485)
+{
+       u32 tcr;
+
+       tcr = dw8250_readl_ext(p, DW_UART_TCR);
+       tcr &= ~DW_UART_TCR_XFER_MODE;
+
+       if (rs485->flags & SER_RS485_ENABLED) {
+               /* Clear unsupported flags. */
+               rs485->flags &= SER_RS485_ENABLED | SER_RS485_RX_DURING_TX |
+                               SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND;
+               tcr |= DW_UART_TCR_RS485_EN;
+
+               if (rs485->flags & SER_RS485_RX_DURING_TX) {
+                       tcr |= DW_UART_TCR_XFER_MODE_DE_DURING_RE;
+               } else {
+                       /* HW does not support same DE level for tx and rx */
+                       if (!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
+                           !(rs485->flags & SER_RS485_RTS_AFTER_SEND))
+                               return -EINVAL;
+
+                       tcr |= DW_UART_TCR_XFER_MODE_DE_OR_RE;
+               }
+               dw8250_writel_ext(p, DW_UART_DE_EN, 1);
+               dw8250_writel_ext(p, DW_UART_RE_EN, 1);
+       } else {
+               rs485->flags = 0;
+
+               tcr &= ~DW_UART_TCR_RS485_EN;
+       }
+
+       /* Reset to default polarity */
+       tcr |= DW_UART_TCR_DE_POL;
+       tcr &= ~DW_UART_TCR_RE_POL;
+
+       if (!(rs485->flags & SER_RS485_RTS_ON_SEND))
+               tcr &= ~DW_UART_TCR_DE_POL;
+       if (device_property_read_bool(p->dev, "rs485-rx-active-high"))
+               tcr |= DW_UART_TCR_RE_POL;
+
+       dw8250_writel_ext(p, DW_UART_TCR, tcr);
+
+       rs485->delay_rts_before_send = 0;
+       rs485->delay_rts_after_send = 0;
+
+       p->rs485 = *rs485;
+
+       return 0;
+}
+
+/*
+ * Tests if RE_EN register can have non-zero value to see if RS-485 HW support
+ * is present.
+ */
+static bool dw8250_detect_rs485_hw(struct uart_port *p)
+{
+       u32 reg;
+
+       dw8250_writel_ext(p, DW_UART_RE_EN, 1);
+       reg = dw8250_readl_ext(p, DW_UART_RE_EN);
+       dw8250_writel_ext(p, DW_UART_RE_EN, 0);
+       return reg;
+}
+
 void dw8250_setup_port(struct uart_port *p)
 {
        struct dw8250_port_data *pd = p->private_data;
@@ -78,6 +156,10 @@ void dw8250_setup_port(struct uart_port *p)
        struct uart_8250_port *up = up_to_u8250p(p);
        u32 reg;
 
+       pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
+       if (pd->hw_rs485_support)
+               p->rs485_config = dw8250_rs485_config;
+
        /*
         * If the Component Version Register returns zero, we know that
         * ADDITIONAL_FEATURES are not enabled. No need to go any further.

diff --git a/drivers/tty/serial/8250/8250_dwlib.h b/drivers/tty/serial/8250/8250_dwlib.h
index b10e60a5d16a5507aba0424bcdb195f78e135c9e..055bfdc87985736aee5ad3bf20360099aa066ee9 100644 (file)
--- a/drivers/tty/serial/8250/8250_dwlib.h
+++ b/drivers/tty/serial/8250/8250_dwlib.h
@@ -20,6 +20,9 @@ struct dw8250_port_data {
 
        /* Hardware configuration */
        u8                      dlf_size;
+
+       /* RS485 variables */
+       bool                    hw_rs485_support;
 };
 
 struct dw8250_platform_data {