mlxsw: reg: Drop unnecessary writes from mlxsw_reg_sfmr_pack()
authorPetr Machata <petrm@nvidia.com>
Mon, 20 Nov 2023 18:25:23 +0000 (19:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 21 Nov 2023 22:53:08 +0000 (14:53 -0800)
The MLXSW_REG_ZERO at the beginning of the function wipes the whole
payload. There's no need to set vtfp and vv to false explicitly.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/04a51ea7cf31eea0ef7707311d8e864e2d9ef307.1700503644.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/reg.h

index ec0adddd459857e4afe11b0212a289b85888202c..e8f7a4741bd3f1f9706f31042563f8893a996a32 100644 (file)
@@ -1973,8 +1973,6 @@ static inline void mlxsw_reg_sfmr_pack(char *payload,
        mlxsw_reg_sfmr_op_set(payload, op);
        mlxsw_reg_sfmr_fid_set(payload, fid);
        mlxsw_reg_sfmr_fid_offset_set(payload, fid_offset);
-       mlxsw_reg_sfmr_vtfp_set(payload, false);
-       mlxsw_reg_sfmr_vv_set(payload, false);
        mlxsw_reg_sfmr_flood_rsp_set(payload, flood_rsp);
        mlxsw_reg_sfmr_flood_bridge_type_set(payload, bridge_type);
        mlxsw_reg_sfmr_smpe_valid_set(payload, smpe_valid);