staging: r8188eu: don't check bSurpriseRemoved in SwLedOff
authorMartin Kaiser <martin@kaiser.cx>
Sun, 25 Sep 2022 14:04:05 +0000 (16:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Sep 2022 08:34:44 +0000 (10:34 +0200)
The SwLedOff function calls rtw_read8 which in turn calls usb_read.

bSurpriseRemoved is checked in usb_read. We don't have to check it again
in SwLedOff.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220925140406.112991-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 989808a2b171e34957e8bbad44a0b0bad928fc8f..d3bd9a97efdcfe2c2af8fdd34f407d39199a2281 100644 (file)
@@ -51,7 +51,7 @@ static void SwLedOff(struct adapter *padapter, struct led_priv *pLed)
        u8      LedCfg;
        int res;
 
-       if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
+       if (padapter->bDriverStopped)
                goto exit;
 
        res = rtw_read8(padapter, REG_LEDCFG2, &LedCfg);/* 0x4E */