drm/bridge: anx7625: Fix overflow issue on reading EDID
authorPin-Yen Lin <treapking@chromium.org>
Thu, 10 Feb 2022 10:38:27 +0000 (18:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:31 +0000 (14:23 +0200)
[ Upstream commit d5c6f647aec9ed524aedd04a3aec5ebc21d39007 ]

The length of EDID block can be longer than 256 bytes, so we should use
`int` instead of `u8` for the `edid_pos` variable.

Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220210103827.402436-1-treapking@chromium.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/analogix/anx7625.c

index ea414cd349b5cab99fc12c9e9f459142d4db8d4c..392a9c56e9a00cea04edd338eed992d773a57a3d 100644 (file)
@@ -791,7 +791,8 @@ static int segments_edid_read(struct anx7625_data *ctx,
 static int sp_tx_edid_read(struct anx7625_data *ctx,
                           u8 *pedid_blocks_buf)
 {
-       u8 offset, edid_pos;
+       u8 offset;
+       int edid_pos;
        int count, blocks_num;
        u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
        u8 i, j;