ACPI: fan: Convert to use sysfs_emit_at() API
authorye xingchen <ye.xingchen@zte.com.cn>
Tue, 6 Dec 2022 07:19:45 +0000 (15:19 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 6 Dec 2022 11:44:14 +0000 (12:44 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/fan_attr.c

index f15157d40713efd98f39eb9ba550b8ed77c7d843..f4f6e2381f1d3af4e3071d325da81dbf9d87ee01 100644 (file)
@@ -27,24 +27,24 @@ static ssize_t show_state(struct device *dev, struct device_attribute *attr, cha
                count = scnprintf(buf, PAGE_SIZE, "%lld:", fps->control);
 
        if (fps->trip_point == 0xFFFFFFFF || fps->trip_point > 9)
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "not-defined:");
+               count += sysfs_emit_at(buf, count, "not-defined:");
        else
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "%lld:", fps->trip_point);
+               count += sysfs_emit_at(buf, count, "%lld:", fps->trip_point);
 
        if (fps->speed == 0xFFFFFFFF)
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "not-defined:");
+               count += sysfs_emit_at(buf, count, "not-defined:");
        else
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "%lld:", fps->speed);
+               count += sysfs_emit_at(buf, count, "%lld:", fps->speed);
 
        if (fps->noise_level == 0xFFFFFFFF)
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "not-defined:");
+               count += sysfs_emit_at(buf, count, "not-defined:");
        else
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "%lld:", fps->noise_level * 100);
+               count += sysfs_emit_at(buf, count, "%lld:", fps->noise_level * 100);
 
        if (fps->power == 0xFFFFFFFF)
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "not-defined\n");
+               count += sysfs_emit_at(buf, count, "not-defined\n");
        else
-               count += scnprintf(&buf[count], PAGE_SIZE - count, "%lld\n", fps->power);
+               count += sysfs_emit_at(buf, count, "%lld\n", fps->power);
 
        return count;
 }