drm/i915/display: Use correct method to free crtc_state
authorSuraj Kandpal <suraj.kandpal@intel.com>
Tue, 10 Oct 2023 18:31:01 +0000 (00:01 +0530)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 11 Oct 2023 21:40:49 +0000 (00:40 +0300)
Even though there is no leaking of resource here lets
just use the correct method to free crtc_state

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231010183101.704439-3-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_dpll.c

index 2255ad65148659d9479c2a605e701cbbad090555..d41c1dc9f66c6580e8954ad91012a05d41a801c2 100644 (file)
@@ -7,6 +7,7 @@
 #include <linux/string_helpers.h>
 
 #include "i915_reg.h"
+#include "intel_atomic.h"
 #include "intel_crtc.h"
 #include "intel_cx0_phy.h"
 #include "intel_de.h"
@@ -2006,7 +2007,7 @@ int vlv_force_pll_on(struct drm_i915_private *dev_priv, enum pipe pipe,
                vlv_enable_pll(crtc_state);
        }
 
-       kfree(crtc_state);
+       intel_crtc_destroy_state(&crtc->base, &crtc_state->uapi);
 
        return 0;
 }