serial: 8250_dw: Emit an error message if getting the baudclk failed
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 22 Feb 2024 11:19:23 +0000 (12:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Mar 2024 21:04:34 +0000 (22:04 +0100)
Instead of silently giving up, at least tell what the problem is.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240222111922.2016122-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dw.c

index 2d1f350a4bea2a86103d707cc322ded0f5941abb..94aa3dddb71ebf39ab58fbef45a341d8da2c89df 100644 (file)
@@ -597,7 +597,8 @@ static int dw8250_probe(struct platform_device *pdev)
        if (data->clk == NULL)
                data->clk = devm_clk_get_optional_enabled(dev, NULL);
        if (IS_ERR(data->clk))
-               return PTR_ERR(data->clk);
+               return dev_err_probe(dev, PTR_ERR(data->clk),
+                                    "failed to get baudclk\n");
 
        INIT_WORK(&data->clk_work, dw8250_clk_work_cb);
        data->clk_notifier.notifier_call = dw8250_clk_notifier_cb;