staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/

Remove all commented out TR_TRACE calls.

Remove all of the RT_TRACE logs in hal/ and os_dep/ file as they
currently do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged. Moreover it relies on an unneeded
private log level tracing which overrides the in-kernel public one,
so just remove them as they are unused.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/85338f2b2cffb530efbd987064d146fc2be49c72.1617640221.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 12f0e36015317583ea5e09cdf03abd8fbd9bc00c..c36513812d9d9f4ee223443ff2950a9d10ae35c8 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -1847,7 +1847,6 @@ void PHY_IQCalibrate_8723B(
                                bResult = FAIL;
                                break;
                        }
-                       /* RT_TRACE(_module_mp_, _drv_notice_, ("Switch to S1 TxIQC(offset, data) = (0x%X, 0x%X)\n", offset, data)); */
                        PHY_SetBBReg(pDM_Odm->Adapter, offset, bMaskDWord, data);
                }
 
@@ -1864,7 +1863,6 @@ void PHY_IQCalibrate_8723B(
                                bResult = FAIL;
                                break;
                        }
-                       /* RT_TRACE(_module_mp_, _drv_notice_, ("Switch to S1 RxIQC (offset, data) = (0x%X, 0x%X)\n", offset, data)); */
                        PHY_SetBBReg(pDM_Odm->Adapter, offset, bMaskDWord, data);
                }
 
@@ -1950,7 +1948,6 @@ void PHY_IQCalibrate_8723B(
                        }
                }
        }
-/*     RT_TRACE(COMP_INIT, DBG_LOUD, ("Release Mutex in IQCalibrate\n")); */
 
        for (i = 0; i < 4; i++) {
                RegE94 = result[i][0];

diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 9b16265b543ddb5c03867afa8787e0a16714f544..f52cc4e7a6e6b1ff5f1126d0a40da4b254fda3f0 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -1785,7 +1785,6 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
        /*
        if (band_type == BAND_ON_5G && pwr_lmt == MAX_POWER_INDEX) {
                if (idx_bandwidth == 0 || idx_bandwidth == 1) {
-                       RT_TRACE(COMP_INIT, DBG_LOUD, ("No power limit table of the specified band %d, bandwidth %d, ratesection %d, rf path %d\n",
                                 idx_band, idx_bandwidth,
                                 idx_rate_sctn, rf_path));
                        if (idx_rate_sctn == 2)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index b90b225d95895c1d65449b7d1dbcc448d9416556..39fb659bc06f9b83e4130c1c55b71847bcdee8b9 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -2583,7 +2583,6 @@ void Hal_EfuseParseEEPROMVer_8723B(
 {
        struct hal_com_data     *pHalData = GET_HAL_DATA(padapter);
 
-/*     RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */
        if (!AutoLoadFail)
                pHalData->EEPROMVersion = hwinfo[EEPROM_VERSION_8723B];
        else
@@ -2662,7 +2661,6 @@ void Hal_EfuseParseCustomerID_8723B(
 {
        struct hal_com_data     *pHalData = GET_HAL_DATA(padapter);
 
-/*     RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */
        if (!AutoLoadFail)
                pHalData->EEPROMCustomerID = hwinfo[EEPROM_CustomID_8723B];
        else
@@ -2683,7 +2681,6 @@ void Hal_EfuseParseXtal_8723B(
 {
        struct hal_com_data     *pHalData = GET_HAL_DATA(padapter);
 
-/*     RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */
        if (!AutoLoadFail) {
                pHalData->CrystalCap = hwinfo[EEPROM_XTAL_8723B];
                if (pHalData->CrystalCap == 0xFF)
@@ -2699,7 +2696,6 @@ void Hal_EfuseParseThermalMeter_8723B(
 {
        struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
 
-/*     RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, ("%s(): AutoLoadFail = %d\n", __func__, AutoLoadFail)); */
        /*  */
        /*  ThermalMeter from EEPROM */
        /*  */
@@ -3001,8 +2997,6 @@ static void rtl8723b_fill_default_txdesc(
 
                ptxdesc->usb_txagg_num = pxmitframe->agg_num;
        } else if (pxmitframe->frame_tag == MGNT_FRAMETAG) {
-/*             RT_TRACE(_module_hal_xmit_c_, _drv_notice_, ("%s: MGNT_FRAMETAG\n", __func__)); */
-
                ptxdesc->macid = pattrib->mac_id; /*  CAM_ID(MAC_ID) */
                ptxdesc->qsel = pattrib->qsel;
                ptxdesc->rate_id = pattrib->raid; /*  Rate ID */
@@ -3776,9 +3770,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val)
                                ulCommand = ulCommand | CAM_POLLINIG | CAM_WRITE;
                                /*  write content 0 is equall to mark invalid */
                                rtw_write32(padapter, WCAMI, ulContent);  /* mdelay(40); */
-                               /* RT_TRACE(COMP_SEC, DBG_LOUD, ("CAM_empty_entry(): WRITE A4: %lx\n", ulContent)); */
                                rtw_write32(padapter, RWCAM, ulCommand);  /* mdelay(40); */
-                               /* RT_TRACE(COMP_SEC, DBG_LOUD, ("CAM_empty_entry(): WRITE A0: %lx\n", ulCommand)); */
                        }
                }
                break;

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
index 73b47f053549ffa0f6d3ad735265a2687253281d..38228b46b1eeec5d2febc16e783d8a7206801b65 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
@@ -74,7 +74,6 @@ void PHY_RF6052SetBandwidth8723B(
                break;
 
        default:
-               /* RT_TRACE(COMP_DBG, DBG_LOUD, ("PHY_SetRF8225Bandwidth(): unknown Bandwidth: %#X\n", Bandwidth)); */
                break;
        }
 
@@ -153,7 +152,6 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
 
        ODM_ConfigRFWithTxPwrTrackHeaderFile(&pHalData->odmpriv);
 
-       /* RT_TRACE(COMP_INIT, DBG_LOUD, ("<---phy_RF6052_Config_ParaFile()\n")); */
        return _SUCCESS;
 }
 

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index cf8e783dc35c4a10bc5f0fbd81172163b8396b6a..5b3976216d71f0bdb0043ae08115cb7c8c696b41 100644 (file)
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -4178,7 +4178,6 @@ static int rtw_wx_set_priv(struct net_device *dev,
        struct adapter *padapter = rtw_netdev_priv(dev);
        struct iw_point *dwrq = (struct iw_point *)awrq;
 
-       /* RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_notice_, ("+rtw_wx_set_priv\n")); */
        if (dwrq->length == 0)
                return -EFAULT;
 
@@ -4192,11 +4191,6 @@ static int rtw_wx_set_priv(struct net_device *dev,
                return -EFAULT;
        }
 
-
-       /* RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_notice_, */
-       /*       ("rtw_wx_set_priv: %s req =%s\n", */
-       /*        dev->name, ext)); */
-
        #ifdef DEBUG_RTW_WX_SET_PRIV
        ext_dbg = vmalloc(len);
        if (!ext_dbg) {