pwm: bcm2835: Introduce a local variable for &pdev->dev
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 10 Mar 2024 13:47:19 +0000 (14:47 +0100)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 30 Apr 2024 16:57:08 +0000 (18:57 +0200)
&pdev->dev is used several times in bcm2835_pwm_probe(). Introduce a
local variable to simplify all usages.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/3f302472e30e21c7ef5624a1d0a2890d9fdf3c7f.1710078146.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/pwm-bcm2835.c

index aa35acbb0cbcf5dd9aa0ca6f73d53e297c097cdd..3d0c089c9ef00ee25c6eb6269e5550de6041aa65 100644 (file)
@@ -133,11 +133,12 @@ static void devm_clk_rate_exclusive_put(void *data)
 
 static int bcm2835_pwm_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct pwm_chip *chip;
        struct bcm2835_pwm *pc;
        int ret;
 
-       chip = devm_pwmchip_alloc(&pdev->dev, 2, sizeof(*pc));
+       chip = devm_pwmchip_alloc(dev, 2, sizeof(*pc));
        if (IS_ERR(chip))
                return PTR_ERR(chip);
        pc = to_bcm2835_pwm(chip);
@@ -146,24 +147,24 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
        if (IS_ERR(pc->base))
                return PTR_ERR(pc->base);
 
-       pc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
+       pc->clk = devm_clk_get_enabled(dev, NULL);
        if (IS_ERR(pc->clk))
-               return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
+               return dev_err_probe(dev, PTR_ERR(pc->clk),
                                     "clock not found\n");
 
        ret = clk_rate_exclusive_get(pc->clk);
        if (ret)
-               return dev_err_probe(&pdev->dev, ret,
+               return dev_err_probe(dev, ret,
                                     "fail to get exclusive rate\n");
 
-       ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
+       ret = devm_add_action_or_reset(dev, devm_clk_rate_exclusive_put,
                                       pc->clk);
        if (ret)
                return ret;
 
        pc->rate = clk_get_rate(pc->clk);
        if (!pc->rate)
-               return dev_err_probe(&pdev->dev, -EINVAL,
+               return dev_err_probe(dev, -EINVAL,
                                     "failed to get clock rate\n");
 
        chip->ops = &bcm2835_pwm_ops;
@@ -171,10 +172,9 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, pc);
 
-       ret = devm_pwmchip_add(&pdev->dev, chip);
+       ret = devm_pwmchip_add(dev, chip);
        if (ret < 0)
-               return dev_err_probe(&pdev->dev, ret,
-                                    "failed to add pwmchip\n");
+               return dev_err_probe(dev, ret, "failed to add pwmchip\n");
 
        return 0;
 }