NFSv4.2 fix kfree in __nfs42_copy_file_range

This is triggering problems with static analysis with Coverity

Reported-by: Colin King <colin.king@netapp.com>
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
index b054d57e77d95a0f1b1fa3d856b1cb669366d862..ef8c16779f4cfba0e3a742a49169113f64ee8601 100644 (file)
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -177,7 +177,8 @@ retry:
        ret = nfs42_proc_copy(file_in, pos_in, file_out, pos_out, count,
                                nss, cnrs, sync);
 out:
-       kfree(cn_resp);
+       if (!nfs42_files_from_same_server(file_in, file_out))
+               kfree(cn_resp);
        if (ret == -EAGAIN)
                goto retry;
        return ret;