usb: clean up after dropping driver registration log spam
authorArd Biesheuvel <ardb@kernel.org>
Mon, 5 Sep 2022 11:17:40 +0000 (13:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Sep 2022 11:23:28 +0000 (13:23 +0200)
Drop another couple of pointless pr_info() calls, and drop a number of
instances of hcd_name variables that are no longer referenced now that
they are no longer printed to the log at driver registration time.

Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20220905111740.352348-1-ardb@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
16 files changed:
drivers/usb/host/ehci-atmel.c
drivers/usb/host/ehci-exynos.c
drivers/usb/host/ehci-npcm7xx.c
drivers/usb/host/ehci-orion.c
drivers/usb/host/ehci-platform.c
drivers/usb/host/ehci-spear.c
drivers/usb/host/ehci-st.c
drivers/usb/host/ohci-at91.c
drivers/usb/host/ohci-exynos.c
drivers/usb/host/ohci-platform.c
drivers/usb/host/ohci-pxa27x.c
drivers/usb/host/ohci-s3c2410.c
drivers/usb/host/ohci-spear.c
drivers/usb/host/ohci-st.c
drivers/usb/host/u132-hcd.c
drivers/usb/host/uhci-hcd.c

index 0e995019c1df915e0057b335cef3f1d832615203..8b775e7bab066541f192f658ee81c57b53997829 100644 (file)
@@ -25,8 +25,6 @@
 
 #define DRIVER_DESC "EHCI Atmel driver"
 
-static const char hcd_name[] = "ehci-atmel";
-
 #define EHCI_INSNREG(index)                    ((index) * 4 + 0x90)
 #define EHCI_INSNREG08_HSIC_EN                 BIT(2)
 
index a65e365e3a047ed9b0ff600ee85eaad9a46ee33c..c8e152c2e0ce6db3f50cb46288574b578316a4f5 100644 (file)
@@ -32,7 +32,6 @@
        (EHCI_INSNREG00_ENA_INCR16 | EHCI_INSNREG00_ENA_INCR8 | \
         EHCI_INSNREG00_ENA_INCR4 | EHCI_INSNREG00_ENA_INCRX_ALIGN)
 
-static const char hcd_name[] = "ehci-exynos";
 static struct hc_driver __read_mostly exynos_ehci_hc_driver;
 
 #define PHY_NUMBER 3
index f4060b3cba1a8687bc37015713daba9b2036bd55..63af1a827fcbc2cb34041aa2bad95a38057afac4 100644 (file)
@@ -24,7 +24,6 @@
 
 #define DRIVER_DESC "EHCI npcm7xx driver"
 
-static const char hcd_name[] = "npcm7xx-ehci";
 static struct hc_driver __read_mostly ehci_npcm7xx_hc_driver;
 
 static int __maybe_unused ehci_npcm7xx_drv_suspend(struct device *dev)
index 2c8b1e6f1fffebf3efc95c7c784782470572a652..a3454a3ea4e0006f74d0e8ee5357895eb6cd4d75 100644 (file)
@@ -65,8 +65,6 @@ struct orion_ehci_hcd {
        struct phy *phy;
 };
 
-static const char hcd_name[] = "ehci-orion";
-
 static struct hc_driver __read_mostly ehci_orion_hc_driver;
 
 /*
index 50491eea94092c7b81ee50d9c693d308c4650296..fe497c876d76899bfde7535bc40447d0e4625d90 100644 (file)
@@ -53,8 +53,6 @@ struct ehci_platform_priv {
        struct delayed_work poll_work;
 };
 
-static const char hcd_name[] = "ehci-platform";
-
 static int ehci_platform_reset(struct usb_hcd *hcd)
 {
        struct platform_device *pdev = to_platform_device(hcd->self.controller);
index 13369289d9cc286e868854358a79d61c00b859fa..c4ddd1022f60c2576718d04c62fdb7b780a4e01e 100644 (file)
@@ -24,8 +24,6 @@
 
 #define DRIVER_DESC "EHCI SPEAr driver"
 
-static const char hcd_name[] = "SPEAr-ehci";
-
 struct spear_ehci {
        struct clk *clk;
 };
index 1086078133f8ba4e90302979d013ff2d4f51d6d5..f731dc98c5331ab7ac2e0338787598e1d20d3d0d 100644 (file)
@@ -42,8 +42,6 @@ struct st_ehci_platform_priv {
 #define hcd_to_ehci_priv(h) \
        ((struct st_ehci_platform_priv *)hcd_to_ehci(h)->priv)
 
-static const char hcd_name[] = "ehci-st";
-
 #define EHCI_CAPS_SIZE 0x10
 #define AHB2STBUS_INSREG01 (EHCI_CAPS_SIZE + 0x84)
 
index adf0998f02992e8ea6a4ca9922f990a3d6a68f41..533537ef3c21db8a7c54d4116b2c8cb2dcd2d599 100644 (file)
@@ -62,8 +62,6 @@ struct ohci_at91_priv {
 
 #define DRIVER_DESC "OHCI Atmel driver"
 
-static const char hcd_name[] = "ohci-atmel";
-
 static struct hc_driver __read_mostly ohci_at91_hc_driver;
 
 static const struct ohci_driver_overrides ohci_at91_drv_overrides __initconst = {
index a060be6ae27423c5b44141127e1e6d9b712600bc..8d7977fd5d3bd502960b6cc81b9ad227a5389f1e 100644 (file)
@@ -21,7 +21,6 @@
 
 #define DRIVER_DESC "OHCI Exynos driver"
 
-static const char hcd_name[] = "ohci-exynos";
 static struct hc_driver __read_mostly exynos_ohci_hc_driver;
 
 #define to_exynos_ohci(hcd) (struct exynos_ohci_hcd *)(hcd_to_ohci(hcd)->priv)
index 79f5c4e08c52c3681fbb5aae0da965888ae8daca..a84305091c434874a4e3d3555fbfe40cc91b60f3 100644 (file)
@@ -41,8 +41,6 @@ struct ohci_platform_priv {
        struct reset_control *resets;
 };
 
-static const char hcd_name[] = "ohci-platform";
-
 static int ohci_platform_power_on(struct platform_device *dev)
 {
        struct usb_hcd *hcd = platform_get_drvdata(dev);
index f2504b884e92e0918311ceb3d269a70185fa6744..a1dad8745622c003035cc1c3e85128855b4b0553 100644 (file)
 
 #define PXA_UHC_MAX_PORTNUM    3
 
-static const char hcd_name[] = "ohci-pxa27x";
-
 static struct hc_driver __read_mostly ohci_pxa27x_hc_driver;
 
 struct pxa27x_ohci {
index 7207c7a3cf492e77fc5ba8c93f0cb2c2fb672a2a..85a0a9ae0095402c4152f74800bd5f74fbdc1afc 100644 (file)
@@ -39,8 +39,6 @@
 
 #define DRIVER_DESC "OHCI S3C2410 driver"
 
-static const char hcd_name[] = "ohci-s3c2410";
-
 static struct clk *clk;
 static struct clk *usb_clk;
 
index 71a3f18fe1be553a4e11c554b686d987db4769d3..196951a27f3f27356e61f2c7fb3a8e181725e2d6 100644 (file)
@@ -23,7 +23,6 @@
 
 #define DRIVER_DESC "OHCI SPEAr driver"
 
-static const char hcd_name[] = "SPEAr-ohci";
 struct spear_ohci {
        struct clk *clk;
 };
index 2e542a344aae814384e39efc84f70e5631c64de0..82eef3c62e11d28ae0afbdcac1cf9f398a09317f 100644 (file)
@@ -40,8 +40,6 @@ struct st_ohci_platform_priv {
 #define hcd_to_ohci_priv(h) \
        ((struct st_ohci_platform_priv *)hcd_to_ohci(h)->priv)
 
-static const char hcd_name[] = "ohci-st";
-
 static int st_ohci_platform_power_on(struct platform_device *dev)
 {
        struct usb_hcd *hcd = platform_get_drvdata(dev);
index d879d6af57105a3df049d56056beb7f05e2843ef..95240c9c45bdbb2772cf12df6ff51d2102e554ff 100644 (file)
@@ -3190,7 +3190,6 @@ static int __init u132_hcd_init(void)
        u132_exiting = 0;
        if (usb_disabled())
                return -ENODEV;
-       printk(KERN_INFO "driver %s\n", hcd_name);
        workqueue = create_singlethread_workqueue("u132");
        if (!workqueue)
                return -ENOMEM;
index d90b869f5f409a801e3cab39304fd09219aaa6e8..c22b51af83fcb9d0fb8630d4181494750014af8e 100644 (file)
@@ -867,8 +867,6 @@ static int __init uhci_hcd_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       printk(KERN_INFO "uhci_hcd: " DRIVER_DESC "%s\n",
-                       ignore_oc ? ", overcurrent ignored" : "");
        set_bit(USB_UHCI_LOADED, &usb_hcds_loaded);
 
 #ifdef CONFIG_DYNAMIC_DEBUG