powerpc/cell: Code cleanup for spufs_mfc_flush
authorKunwu Chan <chentao@kylinos.cn>
Fri, 26 Jan 2024 02:12:58 +0000 (10:12 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 May 2024 13:46:16 +0000 (23:46 +1000)
This part was commented from commit a33a7d7309d7
("[PATCH] spufs: implement mfc access for PPE-side DMA")
in about 18 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240126021258.574916-1-chentao@kylinos.cn
arch/powerpc/platforms/cell/spufs/file.c

index 02a8158c469ddf71b6a9f7424b455f0756c1025e..7f4e0db8eb086f9d28146e19a96146613bdd5207 100644 (file)
@@ -1704,23 +1704,11 @@ static int spufs_mfc_flush(struct file *file, fl_owner_t id)
 
        ret = spu_acquire(ctx);
        if (ret)
-               goto out;
-#if 0
-/* this currently hangs */
-       ret = spufs_wait(ctx->mfc_wq,
-                        ctx->ops->set_mfc_query(ctx, ctx->tagwait, 2));
-       if (ret)
-               goto out;
-       ret = spufs_wait(ctx->mfc_wq,
-                        ctx->ops->read_mfc_tagstatus(ctx) == ctx->tagwait);
-       if (ret)
-               goto out;
-#else
-       ret = 0;
-#endif
+               return ret;
+
        spu_release(ctx);
-out:
-       return ret;
+
+       return 0;
 }
 
 static int spufs_mfc_fsync(struct file *file, loff_t start, loff_t end, int datasync)