platform/chrome: cros_ec_typec: Cleanup switch handle return paths
authorPrashant Malani <pmalani@chromium.org>
Mon, 11 Jul 2022 07:23:02 +0000 (07:23 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Jul 2022 12:44:08 +0000 (14:44 +0200)
Some of the return paths for the cros_typec_get_switch_handles()
aren't necessary. Clean up the return paths to only undo the handle
get's which succeeded.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Link: https://lore.kernel.org/r/20220711072333.2064341-9-pmalani@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/chrome/cros_ec_typec.c

index 7cb2e35c4dede5f3a0688e2d7d354640d66616c7..39e6fd4491a99c9ddbed315525abef410436117e 100644 (file)
@@ -157,12 +157,10 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port,
        return 0;
 
 role_sw_err:
-       usb_role_switch_put(port->role_sw);
-ori_sw_err:
        typec_switch_put(port->ori_sw);
-mux_err:
+ori_sw_err:
        typec_mux_put(port->mux);
-
+mux_err:
        return -ENODEV;
 }