media: radio: remove redundant assignment to variable retval
authorColin Ian King <colin.king@canonical.com>
Wed, 22 Jul 2020 15:16:30 +0000 (17:16 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 6 Aug 2020 09:28:21 +0000 (11:28 +0200)
The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/radio/si4713/radio-usb-si4713.c

index 33274189c83c363dc94a65d5d8080d0923331480..2cf36c8abddeacdb70f35feab8994245cc43d32f 100644 (file)
@@ -414,7 +414,7 @@ static int usb_si4713_probe(struct usb_interface *intf,
        struct si4713_usb_device *radio;
        struct i2c_adapter *adapter;
        struct v4l2_subdev *sd;
-       int retval = -ENOMEM;
+       int retval;
 
        dev_info(&intf->dev, "Si4713 development board discovered: (%04X:%04X)\n",
                        id->idVendor, id->idProduct);