RDMA/cma: Remove NULL check before dev_{put, hold}
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 14 Jun 2023 01:43:28 +0000 (09:43 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 20 Jun 2023 15:50:36 +0000 (12:50 -0300)
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there
is no need to check before using dev_{put, hold}, remove it to silence the
warning:

./drivers/infiniband/core/cma.c:4812:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.

Link: https://lore.kernel.org/r/20230614014328.14007-1-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5521
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/cma.c

index 93a1c48d0c3281ff617f6d1daed911266cf3a0bb..5146ef2dbfd9e97af0114e34d0e9999814909d50 100644 (file)
@@ -4805,8 +4805,7 @@ static void cma_make_mc_event(int status, struct rdma_id_private *id_priv,
        event->param.ud.qkey = id_priv->qkey;
 
 out:
-       if (ndev)
-               dev_put(ndev);
+       dev_put(ndev);
 }
 
 static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast)